-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc/ipv6_auto_subnets: improve documentation about subnet generation and RIO #18398
Conversation
@@ -1,2 +1,3 @@ | |||
*/vendor/* | |||
dist/tools/fixdep/fixdep.c | |||
*.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use git add -p
and then hit a
for the file, the whitespaces are removed if you use the following git config:
[apply]
whitespace = fix
[core]
whitespace = blank-at-eol,blank-at-eof,trailing-space,space-before-tab
As neither tabs nor trailing whitespaces have a syntactical meaning in SVG files, I really don't see a reason why those should be ignored.
SVG files are primarily edited in GUIs, and here even just checked in pregenerated b/c the actual source can't be built in the automation. Requiring whitespace cleanliness would be excessive here IMO.
(Yes it's kind of a bug in the generator, but then it'll be better here when it''s fixed there, and until that semi-manual cleanups don't do noone no good).
|
Ok, fine... |
0c70b86
to
5b5c5cc
Compare
Contribution description
This better illustrates how subnet generation works and why we need the Route Information Option in a Router Advertisement to the upstream network for this to properly work.
Testing procedure
Read the documentation generated by CircleCI and see if things make sense.
Issues/PRs references