Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32: move common ESP-IDF configurations to common files #18406

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Aug 7, 2022

Contribution description

This PR moves the ESP-IDF configurations that are common to all ESP32x SoC to common files to avoid further duplication of the these common configuration in subsequent ESP32x SoC implementations.

Testing procedure

Green CI

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Aug 7, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 7, 2022
@gschorcht gschorcht changed the title cpu/esp32/bootloader: move common configuration to a common file cpu/esp32: move common ESP-IDF configurations to common files Aug 7, 2022
@benpicco benpicco enabled auto-merge August 8, 2022 12:37
@benpicco benpicco merged commit 7f5c932 into RIOT-OS:master Aug 8, 2022
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/split_bootloader_config_to_common_an_special branch August 10, 2022 05:01
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants