cpu/esp32: add linker scripts for ESP32-S3 #18409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the linker script for ESP32-S3 and modify the ESP32-C3 linker scripts to be compatible with them. The goal is to use a section list of objects that is common for all ESP32x SoCs in future.
github-actions
bot
added
Area: cpu
gschorcht
added
Type: new feature
benpicco
reviewed
Aug 9, 2022
Comment on lines
225
to
+226
| *components/spi_flash/spi_flash_timing_tuning.*(.literal .literal.* .text .text.*) | ||
| *components/spi_flash/spi_timing_config.*(.literal .literal.* .text .text.*) | ||
| *components/spi_flash/*/spi_timing_config.*(.literal .literal.* .text .text.*) |
There was a problem hiding this comment.
spi_timing_config.c is not used by ESP32 and ESP32-C3. Therefore I did not realize the wrong path before. As I mentioned before, the intention is to use the same list of objects in all linker scripts to ease maintenance, even if not all listed objects are used by all ESP32x SoC variants.
benpicco
approved these changes
Aug 9, 2022
|
@benpicco Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from #18185. It adds the linker script for ESP32-S3 and modify the ESP32-C3 linker scripts to be compatible with them. The goal is to use a section list of objects that is common for all ESP32x SoCs in future.
Testing procedure
Green CI.
Issues/PRs references
Split-off from #18185