-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/{sam0_common, stm32}: select netdev_legacy_api in KConfig #18466
cpu/{sam0_common, stm32}: select netdev_legacy_api in KConfig #18466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, tested with
for test in tests/driver_sam0_eth tests/driver_stm32_eth/; do for board in same54-xpro nucleo-f767zi nucleo-f429zi nucleo-f207zg; do echo $board && /bin/bash -c "source .murdock; JOBS=4 compile ${test} ${board}:gnu"; done; done;
and it seems to fix the problem.
Now that #18423 we can let automerge to the work and don't need to abuse the skip compile test label 😉 |
Also, thank you for such a fast fix! |
CI now fails because of this :(
For some reason CI now fails when compiling |
|
Thanks @maribu |
That is one down. Thanks again reacting so fast! |
Contribution description
This fixes the discrepancy between the
USEMODULE
based dependency resolution and the KConfig based dependency resolution.Testing procedure
CI should build again
Issues/PRs references
follow-up to #18426