pkg: Move versions to dedicated line #18494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
requested review from
jia200x,
aabadie,
fjmolinas,
DipSwitch and
vincent-d
as code owners
github-actions
bot
added
Area: cpu
benpicco
added
Impact: minor
|
Looks like a rebase is needed. |
Makefiles don't do comments, so these were forwarded into the variable. *Most* users would expand the arguments to a shell where it'd be ignored, but not all of them. Contributes-To: RIOT-OS#18489 (This is also where the one version that is added here was removed).
chrysn
force-pushed
the
pkg_version-makefile-is-not-shell
branch
from
77150f8 to
feff412
Compare
|
Thanks -- I missed that comment, should be mergable now. |
benpicco
approved these changes
Sep 26, 2022
kaspar030
added
CI: ready for build
maribu
added
CI: ready for build
chrysn
added
CI: ready for build
maribu
added
CI: ready for build
chrysn
added
CI: ready for build
chrysn
added
Area: build system
benpicco
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefiles don't do comments, so these were forwarded into the variable.
Most users would expand the arguments to a shell where it'd be
ignored, but not all of them.
Contributes-To: #18489
(This is also where the one version that is added here was removed).