Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/filesystem: drop manual mounts #18495

Merged
merged 1 commit into from
Aug 29, 2022
Merged

examples/filesystem: drop manual mounts #18495

merged 1 commit into from
Aug 29, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

File systems should be mounted via vfs_default, not manually by the application.

Also, vfs gained the format sub-command, so no need to provide it in the example application.

Testing procedure

Run the example.

Issues/PRs references

@benpicco
examples/filesystem: drop manual mounts
e657590 
File systems should be mounted via `vfs_default`, not manually by
the application.

Also, `vfs` gained the `format` sub-command, so no need to provide
it in the example application.
@benpicco benpicco requested a review from jia200x as a code owner August 21, 2022 20:56
@github-actions github-actions bot added Area: doc Area: Documentation Area: examples Area: Example Applications labels Aug 21, 2022
@benpicco benpicco requested a review from vincent-d August 21, 2022 20:56
@benpicco benpicco added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Aug 21, 2022
maribu
maribu approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tursting your testing and it is good that users are pointed to vfs mount, vfs umount, and vfs format rather than to application specific shell commands.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 23, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 29, 2022
@maribu maribu enabled auto-merge August 29, 2022 15:32
@maribu maribu merged commit 47e562a into RIOT-OS:master Aug 29, 2022
@benpicco benpicco deleted the examples/filesystem-cleanup branch August 29, 2022 20:01
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
2 participants
@benpicco @maribu