Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/pkg_tinyvcdiff: Initialize mtd->write_size #18529

Merged
merged 1 commit into from
Aug 30, 2022
Merged

tests/pkg_tinyvcdiff: Initialize mtd->write_size #18529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/pkg_tinyvcdiff/fakemtd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ typedef struct {
#define FAKE_MTD_INIT { .mtd = { .driver = &fake_mtd_driver, \
.sector_count = FAKE_MTD_SECTOR_COUNT, \
.pages_per_sector = FAKE_MTD_PAGES_PER_SECTOR, \
.page_size = FAKE_MTD_PAGE_SIZE } }
.page_size = FAKE_MTD_PAGE_SIZE, \
.write_size = 1 } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe setting this to 4 (FAKE_MTD_WRITE_SIZE) or would be more interesting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the write granularity is not enforced by the fake_mtd_driver, I wouldn't expect anything interesting.


#ifdef __cplusplus
}
Expand Down