hashes_cmac: rename to hashes_aes128_cmac #18539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: cleanup
miri64
requested review from
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: LoRa
miri64
force-pushed
the
hashes_cmac/cleanup/rename
branch
from
6643fe6 to
84e3ace
Compare
|
Unittests pass in all commits: Unittest |
|
And |
jia200x
reviewed
Aug 31, 2022
| * @file | ||
| * @brief AES128_CMAC interface definition | ||
| * | ||
| * @author José Ignacio Alamos <[email protected]> |
There was a problem hiding this comment.
I can do it later too, but just in case you are in the mood: could you use my HAW address? That email doesn't exist anymore :(
There was a problem hiding this comment.
well, there are many occurrences of that email in the master branch... I can also do it at some point
There was a problem hiding this comment.
Then I leave that to you :-D
|
(in theory we need a second ACK here since it's an API change) |
jia200x
added
the
CI: ready for build
Do we? The legacy API is still intact. From an API change perspective, I just added |
Yes, but the PR introduces already a deprecation note for a further release. Therefore the API is already being changed. |
miri64
added
the
Process: needs >1 ACK
maribu
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This renames
hashes_cmacto a more precise name:hashes_aes128_cmac. The old name remains as a depercated legacy wrapper.Testing procedure
Unittests should still compile and pass for each commit,
examples/gnrc_lorawanshould still compile and work as expected.Issues/PRs references
None