pkg/lwip: Set netdev callback before driver init #18548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise if the cable is connected at boot the immediate NETDEV_EVENT_ISR event signaling connection will not trigger the isr, and the netdev will not clear its pending event. This explains why the connect/rx event clash seen in "esp32/eth: Don't overwrite queued event with RX packet" (95196fb) only happened with lwIP. Now on my ESP32 board with Ethernet the issue was the opposite (since IDF upgrade), the stuck connected event blocked receive from working. After this change 95196fb can be reverted since even early events are consumed properly.
This reverts commit 95196fb. Not needed since the initial event is now processed properly.
github-actions
bot
added
Area: cpu
|
I didn't test |
gschorcht
reviewed
Sep 3, 2022
benpicco
added
the
CI: ready for build
|
I could reproduce the behavior without this PR. It works with this PR. |
gschorcht
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
lwIP did not set the netdev callback early enough, so events triggered during or right after initialization were lost.
After the IDF upgrade my board could not receive packets via Ethernet anymore since the cable connect event id was still stored as the pending event. This had not been processed by the ISR due to the missing callback, and the stored event id stopped other events from triggering.
This explains why the connect/rx event clash seen in "esp32/eth: Don't overwrite queued event with RX packet" (95196fb) only happened with lwIP. The fix for that is no longer needed and therefore reverted.
Testing procedure
tests/lwipstill works and interfaces can get IPv4 or IPv6 address dynamically (meaning RX & TX works).Issues/PRs references
Broken for me since #17601. Reverting #16084