drivers/sdcard_spi: make 8-bit safe #18572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
int
s andunsigned
s with integers with fixed width1 << 24
is valid on 32-bit, but undefined behavior on 8-bit, as a 16 bit wideint
would be shifted by more than the type width)void *
/const void *
for data buffers to ease useTesting procedure
Issues/PRs references
Fixes issue reported in #18445 (comment)