Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Ubuntu jammy build fixes #18652

Merged
merged 4 commits into from
Sep 27, 2022
Merged

treewide: Ubuntu jammy build fixes #18652

merged 4 commits into from
Sep 27, 2022

Conversation

kaspar030
Copy link
Contributor

Contribution description

Collects build fixes necessary since RIOT-OS/riotdocker#189.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Sep 27, 2022
@github-actions github-actions bot added the Area: pkg Area: External package ports label Sep 27, 2022
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 27, 2022
@github-actions github-actions bot added the Area: examples Area: Example Applications label Sep 27, 2022
@github-actions github-actions bot added the Area: cpu Area: CPU/MCU ports label Sep 27, 2022
@kaspar030 kaspar030 marked this pull request as ready for review September 27, 2022 08:21
@maribu maribu enabled auto-merge September 27, 2022 08:26
@chrysn
Copy link
Member

chrysn commented Sep 27, 2022 •
edited
Loading

Screenshot 2022-09-27 at 14-07-59 Murdock — Pull Requests RIOT-OS_RIOT
The failing Rust tests are due to the docker update; none of the changes affect them. The relevant ones passed. I'm clearing this to be merged without a full build test.

@chrysn chrysn added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2022
@maribu maribu merged commit 1a372d2 into RIOT-OS:master Sep 27, 2022
benpicco
benpicco reviewed Sep 27, 2022
View reviewed changes
examples/micropython/Makefile
@@ -31,4 +31,7 @@ FEATURES_OPTIONAL += periph_spi
# a terminal is opened to synchronize.
TESTRUNNER_RESET_AFTER_TERM ?= 1

# failing on native with floating point exception (#15870)
TEST_ON_CI_BLACKLIST = all
Copy link
Contributor

@benpicco benpicco Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why not?

Suggested change
TEST_ON_CI_BLACKLIST = all
TEST_ON_CI_BLACKLIST = native

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, that was a copy&pasta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18657

@kaspar030 kaspar030 deleted the jammy_fixes branch September 27, 2022 13:02
@kaspar030 kaspar030 mentioned this pull request Sep 27, 2022
Merged
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco left review comments

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: examples Area: Example Applications Area: pkg Area: External package ports Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@kaspar030 @chrysn @benpicco @maribu