Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/tinyusb: add support for SAM0-based boards #18689

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

dylad
Copy link
Member

@dylad dylad commented Oct 4, 2022

Contribution description

This PR add tinyusb pkg support for SAM0-based MCUs.
I used usbdev support as pattern to enable tinyusb on them.
I tested this PR on same54-xpro, samr21-xpro and saml21-xpro

Testing procedure

Use any SAM0-based board declare in this PR with tinyusb:
BOARD=samr21-xpro make -C tests/pkg_tinyusb_cdc_msc flash
tinyusb should works as expected.

Issues/PRs references

None.

@github-actions github-actions bot added Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports labels Oct 4, 2022
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some style nits:

boards/bastwan/Makefile.features Outdated Show resolved Hide resolved
pkg/tinyusb/hw/hw_sam0.c Outdated Show resolved Hide resolved
pkg/tinyusb/hw/Makefile Show resolved Hide resolved
boards/bastwan/Makefile.features Outdated Show resolved Hide resolved
pkg/tinyusb/hw/hw_sam0.c Show resolved Hide resolved
pkg/tinyusb/hw/hw_sam0.c Outdated Show resolved Hide resolved
pkg/tinyusb/hw/hw_sam0.c Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

benpicco commented Oct 5, 2022

Just squash directly

@dylad
Copy link
Member Author

dylad commented Oct 5, 2022

Just squash directly

Will do tonight.

boards/adafruit-itsybitsy-m4/Kconfig Outdated Show resolved Hide resolved
boards/arduino-nano-33-iot/Kconfig Outdated Show resolved Hide resolved
boards/arduino-nano-33-iot/Makefile.features Outdated Show resolved Hide resolved
@dylad dylad force-pushed the pr/pkg_tinyusb/add_sam0_support branch from 1b8085b to 09011b9 Compare October 5, 2022 17:24
@dylad
Copy link
Member Author

dylad commented Oct 5, 2022

I've addressed all comments (I think), remove a bunch of boards because highlevel_stdio module and squash at the same time.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 5, 2022
@riot-ci
Copy link

riot-ci commented Oct 5, 2022

Murdock results

✔️ PASSED

4e39ba4 boards/sam0-based: enable tinyusb_device support in Kconfig

Success Failures Total Runtime
1980 0 1980 06m:46s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@dylad dylad force-pushed the pr/pkg_tinyusb/add_sam0_support branch from 09011b9 to cec9d29 Compare October 5, 2022 17:49
@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 5, 2022
@dylad dylad force-pushed the pr/pkg_tinyusb/add_sam0_support branch from cec9d29 to 4e39ba4 Compare October 5, 2022 18:14
@benpicco benpicco enabled auto-merge October 6, 2022 13:32
@benpicco benpicco merged commit 03ab499 into RIOT-OS:master Oct 6, 2022
@dylad
Copy link
Member Author

dylad commented Oct 6, 2022

Thanks !

@dylad dylad deleted the pr/pkg_tinyusb/add_sam0_support branch October 6, 2022 14:58
@dylad dylad added this to the Release 2022.10 milestone Oct 13, 2022
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Dec 7, 2022
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
Einhornhool pushed a commit to Einhornhool/RIOT that referenced this pull request Jan 24, 2023
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
dylad pushed a commit to dylad/RIOT that referenced this pull request Feb 3, 2023
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants