-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tinyusb: add support for SAM0-based boards #18689
pkg/tinyusb: add support for SAM0-based boards #18689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some style nits:
Just squash directly |
Will do tonight. |
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
1b8085b
to
09011b9
Compare
I've addressed all comments (I think), remove a bunch of boards because |
Murdock results✔️ PASSED 4e39ba4 boards/sam0-based: enable tinyusb_device support in Kconfig
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
09011b9
to
cec9d29
Compare
Signed-off-by: Dylan Laduranty <[email protected]>
cec9d29
to
4e39ba4
Compare
Thanks ! |
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
The `tinyusb_device` feature introduced with PR RIOT-OS#18689 has to be moved from `common/arduino-zero` definition to the `arduino-zero` definition because the common `arduino-zero` features are also used by `wemos-zero` which uses `highlevel_stdio` feature via the `stdio_cdc_acm` module.
Contribution description
This PR add tinyusb pkg support for SAM0-based MCUs.
I used
usbdev
support as pattern to enable tinyusb on them.I tested this PR on
same54-xpro
,samr21-xpro
andsaml21-xpro
Testing procedure
Use any SAM0-based board declare in this PR with tinyusb:
BOARD=samr21-xpro make -C tests/pkg_tinyusb_cdc_msc flash
tinyusb should works as expected.
Issues/PRs references
None.