Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pseudomodules: document gnrc_netif_cmd_lora as deprecated #18706

Merged
merged 1 commit into from
Oct 7, 2022
Merged

pseudomodules: document gnrc_netif_cmd_lora as deprecated #18706

merged 1 commit into from
Oct 7, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 7, 2022

Contribution description

This adds the deprecation of gnrc_netif_cmd_lora that was introduced in #18649 to the documentation list of deprecated things.

Testing procedure

make doc and read doc/doxygen/html/deprecated.html.

Issues/PRs references

Follow-up on #18649 and semantically requires it to be merged.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 7, 2022
@github-actions github-actions bot added the Area: build system Area: Build system label Oct 7, 2022
@miri64 miri64 mentioned this pull request Oct 7, 2022
Merged
@riot-ci
Copy link

riot-ci commented Oct 7, 2022 •
edited
Loading

Murdock results

✔️ PASSED

485c94c pseudomodules: document gnrc_netif_cmd_lora as deprecated

Success Failures Total Runtime
1980 0 1980 08m:25s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64 miri64 force-pushed the pseudomodules/depr/gnrc_netif_cmd_lora branch from 0b1f177 to 9ef753f Compare October 7, 2022 10:11
@benpicco benpicco requested a review from maribu October 7, 2022 10:15
@miri64 miri64 force-pushed the pseudomodules/depr/gnrc_netif_cmd_lora branch from 9ef753f to 485c94c Compare October 7, 2022 10:17
@miri64 miri64 enabled auto-merge October 7, 2022 11:17
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 7, 2022
@miri64
Copy link
Member Author

miri64 commented Oct 7, 2022 •
edited
Loading

Too scared to skip compiling on a build system file change ^^" (I removed the wildcard, so this can actually cause a non-obvious error).

@miri64 miri64 merged commit 30e7891 into RIOT-OS:master Oct 7, 2022
@miri64 miri64 deleted the pseudomodules/depr/gnrc_netif_cmd_lora branch October 7, 2022 19:16
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @benpicco @maribu