Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riotctrl_shell.cord_ep: remove regif parameter #18716

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 10, 2022

Contribution description

The argument regif was removed from the shell command in #18053, so there is not much need to keep it in the ShellInteraction for that command.

Testing procedure

cd dist/pythonlibs/riotctrl_shell; tox

should still succeed

Issues/PRs references

Follow-up on #18053

Also see RIOT-OS/Release-Specs#260 for the fix of release spec 9.1 and the test for it.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 10, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Oct 10, 2022
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 10, 2022
The argument regif was removed from the shell command in RIOT-OS#18053,
so there is not much need to keep it in the ShellInteraction for that command.
@miri64 miri64 force-pushed the riotctrl_shell/cleanup/rm-regif branch from fa72453 to 8c04964 Compare October 10, 2022 08:58
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 10, 2022
@riot-ci
Copy link

riot-ci commented Oct 10, 2022

Murdock results

✔️ PASSED

8c04964 riotctrl_shell.cord_ep: remove regif parameter

Success Failures Total Runtime
1 0 1 01m:01s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2022

cc @Teufelchen1

@maribu maribu enabled auto-merge October 10, 2022 11:25
@maribu maribu merged commit f30f945 into RIOT-OS:master Oct 10, 2022
@miri64 miri64 deleted the riotctrl_shell/cleanup/rm-regif branch October 10, 2022 11:45
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants