tests/gcoap_fileserver: add test for PUT #18725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
miri64,
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner,
fjmolinas,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: CoAP
benpicco
added
the
Type: bug
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
tests/gcoap_fileserver-put
branch
from
3b344b0 to
245aef3
Compare
Murdock results✔️ PASSED 7e0aeb3 tests/gcoap_fileserver: add test for PUT
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
benpicco
force-pushed
the
tests/gcoap_fileserver-put
branch
from
245aef3 to
5c7e8d6
Compare
fabian18
reviewed
Oct 12, 2022
fabian18
reviewed
Oct 12, 2022
benpicco
force-pushed
the
tests/gcoap_fileserver-put
branch
from
5c7e8d6 to
7e0aeb3
Compare
|
Thank you for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds a test for blockwise PUT to
tests/gcoap_fileserver.Doing so uncovered a bug: When a block would be transmitted, but the ACK got lost, the sender would re-transmit the block.
This triggered the
block1.offset != (unsigned)retcheck in the GCoAP fileserver which considered this an error and aborted the transmission.To fix this, simply ignore old blocks and send a
COAP_CODE_CONTINUEanyway.Testing procedure
CI will run
tests/gcoap_fileserver.Issues/PRs references