Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: move actions/checkout to main #18730

Merged
merged 1 commit into from
Oct 13, 2022
Merged

gh-actions: move actions/checkout to main #18730

merged 1 commit into from
Oct 13, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 12, 2022

Contribution description

Github is complaining about deprecation of Node.js 12 deprecation in our Github Actions (one example can be found here: https://github.com/RIOT-OS/RIOT/actions/runs/3235426917) this is due to us using an outdated version of the actions/checkout Action. This bumps all of them to follow the master branch (as some already do, e.g. tools-buildtests).

Testing procedure

See if the Node.js deprecation warning disappears.

Issues/PRs references

None

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Oct 12, 2022
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Oct 12, 2022
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed Area: CI Area: Continuous Integration of RIOT components labels Oct 12, 2022
@riot-ci
Copy link

riot-ci commented Oct 12, 2022 •
edited
Loading

Murdock results

✔️ PASSED

ecf760d gh-actions: move actions/checkout to main

Success Failures Total Runtime
1 0 1 01m:08s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

kfessel
kfessel reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/checkout seems to use main for its main branch master is lacking behind

kfessel
kfessel reviewed Oct 12, 2022
View reviewed changes
.github/workflows/release-test.yml Outdated
@@ -88,14 +88,14 @@ jobs:
ssh -oStrictHostKeyChecking=accept-new \
${IOTLAB_USER}@lille.iot-lab.info exit
- name: Checkout Release-Specs
uses: actions/checkout@v2
uses: actions/checkout@master
Copy link
Contributor

@kfessel kfessel Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work without adding a version (default to Head)?

Suggested change
uses: actions/checkout@master
uses: actions/checkout

seems like github advices against using branches or no version (but the advice sound like no @ would result in HEAD)

or

Suggested change
uses: actions/checkout@master
uses: actions/checkout@main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They got a job that auto updates main to the latest tag https://github.com/actions/checkout/blob/main/.github/workflows/update-main-version.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to main, even the once where we already used master

@miri64 miri64 force-pushed the gh-actions/enh/checkout-master branch from b537a41 to ecf760d Compare October 12, 2022 15:10
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Oct 12, 2022
kfessel
kfessel approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though Github advises softly against using braches for action versions here This seems save at the time of review. As mentioned pr description we did this for some workflows.

@miri64 miri64 changed the title gh-actions: move actions/checkout to master gh-actions: move actions/checkout to main Oct 12, 2022
@miri64 miri64 enabled auto-merge October 12, 2022 15:25
@miri64 miri64 merged commit 10ca5ec into RIOT-OS:master Oct 13, 2022
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
@miri64 miri64 deleted the gh-actions/enh/checkout-master branch October 17, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @kfessel @maribu