sys/clif: Fixing out of bounds read under certain conditions [backport 2022.10] #18810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: sys
Murdock results✔️ PASSED bb7c6d0 sys/clif: Fixing out of bounds read under certain conditions
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
|
waiting for #18812 |
maribu
added
CI: ready for build
kfessel
approved these changes
Oct 28, 2022
(cherry picked from commit 499b635)
benpicco
force-pushed
the
backport/2022.10/fix/clif_0
branch
from
c5407cc to
bb7c6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18744
Hi 😈
This fixes a potential out of bounds read in
clif_encode_link. There is no code in RIOT that can be exploited & and the close bymemcpyonly operates within a safe/length checked buffer.The fix does not break the current API.
I also added a new test which also acts as an example on how to use clif.
Run
make -C tests/unittests tests-clifandmake -C tests/unittests termto test the fix.Side note: I did not run uncrustify as this would have filled this PR with a lot of unrelated changes. Somebody should open a separate PR for those cosmetic changes.
cc @leandrolanzieri