Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_sixlowpan: Various hardening fixes [backport 2022.10] #18820

Merged
merged 10 commits into from
Oct 29, 2022
Merged

gnrc_sixlowpan: Various hardening fixes [backport 2022.10] #18820

merged 10 commits into from
Oct 29, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 29, 2022

Backport of #18817

Contribution description

Title says everything

Testing procedure

Fragmentation and header compression (e.g. as outlined in Release Specs 4 and 6) should still work.

Issues/PRs references

miri64 and others added 10 commits October 29, 2022 09:54
@miri64
gnrc_sixlowpan_iphc: fix buffer overflow in gnrc_sixlowpan_iphc_recv()
da63e45 
(cherry picked from commit 7361516)
@miri64
gnrc_sixlowpan_iphc: fix integer underflow in gnrc_sixlowpan_iphc_recv()
d052e2e 
(cherry picked from commit 2709fbd)
@miri64
gnrc_sixlowpan_frag_rb: fix integer underflow in _6lo_frag_size()
bd31010 
(cherry picked from commit 9728f72)
@Diff-fusion @miri64
gnrc_sixlowpan_iphc: fix null pointer dereference in _iphc_encode()
7253e26 
(cherry picked from commit 639c043)
@miri64
gnrc_sixlowpan_iphc: fix packet type confusion in _iphc_encode()
dafc397 
(cherry picked from commit 4a081f8)
@Diff-fusion @miri64
ieee802154: Adjust parsing of IEEE 802.15.4 frame header
f4df5b4 
(cherry picked from commit 0bec3e2)
@Diff-fusion @miri64
gnrc_netif_ieee802154: Ignore packets without source address
4b23d93 
(cherry picked from commit 17c70f7)
@Diff-fusion @miri64
gnrc_sixlowpan_frag_vrb: Assert no usage of a vrb with src_len == 0
f4fb746 
(cherry picked from commit aa27ed7)
@miri64
gnrc_sixlowpan_iphc.c: dereference ipv6_hdr in DEBUG() after assignment
0cba82a 
(cherry picked from commit 36a099e)
@miri64
tests/unittests: fix get_frame_hdr_len tests for hardened parsing
e82cab6 
(cherry picked from commit 3c7c9fe)
@miri64 miri64 added Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Oct 29, 2022
@miri64 miri64 mentioned this pull request Oct 29, 2022
Merged
@riot-ci
Copy link

riot-ci commented Oct 29, 2022

Murdock results

✔️ PASSED

e82cab6 tests/unittests: fix get_frame_hdr_len tests for hardened parsing

Success Failures Total Runtime
2006 0 2006 07m:46s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@maribu maribu enabled auto-merge October 29, 2022 12:27
@maribu maribu merged commit 99608da into RIOT-OS:2022.10-branch Oct 29, 2022
@miri64 miri64 deleted the backport/2022.10/gnrc_sixlowpan/fix/harden branch October 29, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen haukepetersen is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan cgundogan is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @maribu @Diff-fusion