Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbus/hid: fix buffer overflow in hid_io [backport 2022.10] #18889

Merged
merged 1 commit into from
Nov 13, 2022
Merged

usbus/hid: fix buffer overflow in hid_io [backport 2022.10] #18889

merged 1 commit into from
Nov 13, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 11, 2022

Backport of #18860

Contribution description

This PR fixes a potential buffer overflow inside usb_hid_io_write which occurs when len > CONFIG_USBUS_HID_INTERRUPT_EP_SIZE.

@maribu maribu added Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Nov 11, 2022
@maribu maribu mentioned this pull request Nov 11, 2022
Merged
@riot-ci
Copy link

riot-ci commented Nov 11, 2022 •
edited
Loading

Murdock results

✔️ PASSED

c256544 usbus/hid: fix buffer overflow in hid_io

Success Failures Total Runtime
1983 0 1983 06m:36s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

kfessel
kfessel approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport by release maintainer, changes are identical to master

dylad
dylad approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@benpicco benpicco enabled auto-merge November 13, 2022 17:01
@benpicco benpicco force-pushed the backport/2022.10/usb_hid_fix branch from dc65070 to c256544 Compare November 13, 2022 17:02
@benpicco benpicco merged commit 1e62220 into RIOT-OS:2022.10-branch Nov 13, 2022
@maribu maribu deleted the backport/2022.10/usb_hid_fix branch November 13, 2022 19:49
@maribu
Copy link
Member Author

maribu commented Nov 13, 2022

thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@dylad dylad dylad approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maribu @riot-ci @kfessel @dylad @benpicco @Ollrogge