sys/print_stack_usage: update MIN_SIZE [backport 2022.10] #18924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fmt no longer has a significant advantage in stack consumption, we need to bump the `MIN_SIZE` guard that prevents causing stack overflows due to the printing of the stack consumption. (cherry picked from commit 5b86848)
maribu
added
Area: sys
benpicco
approved these changes
Nov 17, 2022
Murdock results✔️ PASSED 7b54a45 sys/print_stack_usage: update MIN_SIZE
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18917
Contribution description
Since fmt no longer has a significant advantage in stack consumption, we need to bump the
MIN_SIZEguard that prevents causing stack overflows due to the printing of the stack consumption.Testing procedure
Should no longer print stack usage for the dummy POSIX threads and not result in hard faults due to stack overflows anymore.
Issues/PRs references
Better alternative to #18916