build system: fix compilation with LLVM [backport 2022.10] #18928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC on some platforms does need an executable stack to generate trampoline code, but use of nested functions is not allowed in RIOT's code base anyway. (cherry picked from commit 67ba1a0)
The test for the requirement of disabling wchar_t size warnings assumed that $(CC) is used for linking, instead of $(LINK). With GCC $(LINK) and $(CC) happen to be (in most cases) identical, but with LLVM they are not. This results in issues with compiling with LLVM. (cherry picked from commit 0077e9a)
maribu
added
Area: build system
Murdock results✔️ PASSED 158f52d makefiles/libc: fix wchar_t size warnings on LLVM
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
|
Hmmm... A bit late it seems 😕 |
|
Or it just merged as soon as the ack... Cool. |
|
Yes. I enablee auto merge and the ACK was the last checkbox to tick :) |
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18845
Contribution description
-z noexecstackto link flags$(CC)is used for linking, instead of$(LINK). With GCC$(LINK)and$(CC)happen to be (in most cases) identical, but with LLVM they are not. This results in issues with compiling with LLVM.Testing procedure
No change in binaries and everything should still compile.
Issues/PRs references
Inspired by #18844