pkg/tinyusb: add Kconfig support for stdio_tinyusb_cdc_acm #19007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: boards
gschorcht
added
Type: enhancement
Enabling module `periph_uart_hw_fc` makes only sense if module `periph_uart` is used.
weact-f4xcx boards have only a single USB-C connector that is used for `highlevel_stdio` via USBUS CDC ACM so that it conflicts with tinyUSB for the moment.
benpicco
approved these changes
Dec 6, 2022
|
@benpicco Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #18998 and provides the Kconfig support for the
stdio_tinyusb_cdc_acmmodule.It also contains the following fixes due to compilation errors that first occurred with this PR:
periph_uart_hw_fcdependency onperiph_uart, i.e.periph_uart_hw_fcmust be enabled only ifperiph_uartis used.weact-f4x1cxboards that was accidentally added with PR pkg/tinyusb: add tinyUSB as package #18592 and now causes compilation to fail.This PR is now a prerequisite for PR #18998.
Testing procedure
Green CI.
Issues/PRs references
Prerequisite for PR #18998