Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/wolfssl: Fix memory leaks in wolfSSL sock_tls #19190

Merged
merged 1 commit into from
Jan 24, 2023
Merged

pkg/wolfssl: Fix memory leaks in wolfSSL sock_tls #19190

merged 1 commit into from
Jan 24, 2023

Conversation

Flole998
Copy link
Contributor

@Flole998 Flole998 commented Jan 24, 2023 •
edited
Loading

When sk->ssl is NULL it doesn't need to be free()d, otherwise it may be free()d

@github-actions github-actions bot added the Area: pkg Area: External package ports label Jan 24, 2023
benpicco
benpicco approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Thank you for the patch.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 24, 2023
@benpicco
Copy link
Contributor

Ah, one more thing to get this past CI: Please prefix your commit with the subsystem, so

pkg/wolfssl: fix memory leak in tls_session_destroy()

@Flole998
Copy link
Contributor Author

Ah, that's what's wrong. Fixed it.

@Flole998 Flole998 changed the title Fix memory leaks in wolfSSL sock_tls pkg/wolfssl: Fix memory leaks in wolfSSL sock_tls Jan 24, 2023
@riot-ci
Copy link

riot-ci commented Jan 24, 2023 •
edited
Loading

Murdock results

✔️ PASSED

2b1506d pkg/wolfssl: Fix memory leaks in wolfSSL sock_tls

Success Failures Total Runtime
6796 0 6796 12m:38s

Artifacts

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Build succeeded:

@bors bors bot merged commit d1072c2 into RIOT-OS:master Jan 24, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@pokgak pokgak Awaiting requested review from pokgak

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@Flole998 @benpicco @riot-ci @MrKevinWeiss