Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/vfs*: Model kconfig #19403

Closed
wants to merge 3 commits into from
Closed

tests/vfs*: Model kconfig #19403

wants to merge 3 commits into from

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

Simple model of kconfig for vfs tests.

Testing procedure

  • Green murdock
  • For those with extra CPU cycles: ./dist/tools/compile_test/compile_like_murdock.py -a tests/vfs_iterate_mount/ -b all

Issues/PRs references

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Mar 17, 2023
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 17, 2023
@riot-ci
Copy link

riot-ci commented Mar 17, 2023 •
edited
Loading

Murdock results

❌ FAILED

2be3a22 tests/vfs_default: Model kconfig

Success Failures Total Runtime
24 1 29 28s
Build failures (1)
Application Target Toolchain Runtime (s) Worker
tests/vfs_default nrf52840dk gnu 3.06 tatooine

Artifacts

leandrolanzieri
leandrolanzieri reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the symbols seem not to be found

@MrKevinWeiss MrKevinWeiss changed the title Pr/tests/vfs/kconfig tests/vfs/kconfig: Model kconfig Mar 17, 2023
@MrKevinWeiss MrKevinWeiss changed the title tests/vfs/kconfig: Model kconfig tests/vfs*: Model kconfig Mar 17, 2023
@MrKevinWeiss
Copy link
Contributor Author

Yup, I will look into it, I guess not as simple as I had hoped.

@MrKevinWeiss MrKevinWeiss force-pushed the pr/tests/vfs/kconfig branch from 63d43ed to 87da708 Compare March 17, 2023 11:18
@MrKevinWeiss
Copy link
Contributor Author

squashed the fix, I don't think it is helpful for review 😃

leandrolanzieri
leandrolanzieri approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the makefile deps this looks good to me.

@leandrolanzieri leandrolanzieri added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Mar 17, 2023
leandrolanzieri
leandrolanzieri reviewed Mar 17, 2023
View reviewed changes
tests/vfs_default/app.config.test
@@ -0,0 +1,6 @@
CONFIG_MODULE_VFS_DEFAULT=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing CONFIG_MODULE_VFS=y

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@MrKevinWeiss MrKevinWeiss force-pushed the pr/tests/vfs/kconfig branch from 87da708 to 2be3a22 Compare March 17, 2023 13:01
@MrKevinWeiss
Copy link
Contributor Author

hehehe, I see why this wasn't added...

@leandrolanzieri
Copy link
Contributor

hehehe, I see why this wasn't added...

Seems that a bit more modelling is required :)

@MrKevinWeiss MrKevinWeiss removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 20, 2023
@MrKevinWeiss MrKevinWeiss requested a review from jia200x as a code owner March 20, 2023 08:40
@MrKevinWeiss MrKevinWeiss added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Mar 20, 2023
@github-actions github-actions bot added the Area: boards Area: Board ports label Mar 20, 2023
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: sys Area: System Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform labels Mar 20, 2023
@MrKevinWeiss
Copy link
Contributor Author

Needs other modules and packages modelled...

@aabadie
Copy link
Contributor

aabadie commented May 20, 2023

needs rebase

@aabadie aabadie mentioned this pull request May 20, 2023
Closed
@MrKevinWeiss
Copy link
Contributor Author

Also not complete. There are some other things I need to do first for this so we can keep it on the backburner for now.

@aabadie
Copy link
Contributor

aabadie commented May 31, 2023

Also not complete. There are some other things I need to do first for this so we can keep it on the backburner for now.

What is missing ? fs packages ?

@aabadie
Copy link
Contributor

aabadie commented Sep 27, 2024

no longer needed

@aabadie aabadie closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrKevinWeiss @riot-ci @leandrolanzieri @aabadie