Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32: fix stdio_usb_serial_jtag for ESP32-C3 #19415

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR fixes problem with stdio_usb_serial_jtag for ESP32-C3.

Testing procedure

Flash any ESP32-C3 board with the USB interface connected USB D+/D- (GPIO19, GPIO18) using the stdio_usb_serial_jtag module:

USEMODULE=stdio_usb_serial_jtag BOARD=hip-badge make -j8 -C tests/shell flash term

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Mar 21, 2023
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Mar 21, 2023
@gschorcht gschorcht force-pushed the cpu/esp32/fix_stdio_usb_serial_jtag branch from 1a30360 to 28a63f3 Compare March 21, 2023 23:36
@riot-ci
Copy link

riot-ci commented Mar 21, 2023

Murdock results

✔️ PASSED

28a63f3 cpu/esp32: fix stdio_usb_serial_jtag for ESP32-C3

Success Failures Total Runtime
6882 0 6882 09m:41s

Artifacts

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out, now it works reliable!
No idea how this did work before.

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 22, 2023

Build succeeded:

@bors bors bot merged commit 9719bbf into RIOT-OS:master Mar 22, 2023
@gschorcht gschorcht deleted the cpu/esp32/fix_stdio_usb_serial_jtag branch March 24, 2023 11:42
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants