dist/tools/openocd: fix parsing of flash bank base #19620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 80fc9fabc66a0bc767467fa14c703e5a9f340cd3 the format of the `flash list` command changed to a more human readable multi-line variant. Technically, the change is white-space only. Still, the current approach of parsing them with awk, sed and cut doesn't like the new multi-line format. The parsing is now delegated into a python script that is compatible across OpenOCD versions.
benpicco
added
the
CI: ready for build
aabadie
approved these changes
May 23, 2023
There was a problem hiding this comment.
Code change is good and I like the approach of using Python for parsing the output of "flash list". I tested this on nucleo-l476rg for which I have an issue when testing tests/riotboot with the latest openocd version. With this PR it works on old and latest OpenOCD. It is also working on both OpenOCD versions with nrf52840dk.
ACK
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 23, 2023
19620: dist/tools/openocd: fix parsing of flash bank base r=aabadie a=maribu ### Contribution description Since [80fc9fabc66a0bc767467fa14c703e5a9f340cd3] the format of the `flash list` command changed to a more human readable multi-line variant. Technically, the change is white-space only. Still, the current approach of parsing them with awk, sed and cut doesn't like the new multi-line format. The parsing is now delegated into a python script that is compatible across OpenOCD versions. [80fc9fabc66a0bc767467fa14c703e5a9f340cd3]: openocd-org/openocd@80fc9fa 19636: sys: model ecc, evtimer, pipe and shell_lock in kconfig r=aabadie a=aabadie 19639: tests/net/gnrc_mac_timeout: add automated test r=aabadie a=aabadie Co-authored-by: Marian Buschsieweke <[email protected]> Co-authored-by: Alexandre Abadie <[email protected]>
|
Build failed (retrying...): |
|
bors merge |
|
Already running a review |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thx :) |
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Jun 20, 2023
fabian18
pushed a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Jun 26, 2023
fabian18
pushed a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Sep 17, 2023
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Nov 10, 2023
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Nov 29, 2023
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Dec 14, 2023
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Jan 3, 2024
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Jan 23, 2024
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Apr 5, 2024
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Jul 26, 2024
fabian18
pushed a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Sep 17, 2024
benpicco
added a commit
to ML-PA-Consulting-GmbH/RIOT
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Since 80fc9fabc66a0bc767467fa14c703e5a9f340cd3 the format of the
flash listcommand changed to a more human readable multi-line variant. Technically, the change is white-space only. Still, the current approach of parsing them with awk, sed and cut doesn't like the new multi-line format. The parsing is now delegated into a python script that is compatible across OpenOCD versions.Testing procedure
Should now work even with an fresh OpenOCD build from git
Issues/PRs references
Found while looking into #14576