-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/can: model in kconfig #19675
sys/can: model in kconfig #19675
Conversation
be36322
to
694bc9e
Compare
Is that actually what we want? It would seem this is only due to int conn_can_isotp_recv(conn_can_isotp_t *conn, void *buf, size_t size, uint32_t timeout)
{
assert(conn != NULL);
assert(buf != NULL);
int ret = 0;
gnrc_pktsnip_t *snip;
if (!conn->bound) {
return -ENOTCONN;
}
|
unless this |
Not only, there's also Lines 92 to 99 in e690ef4
|
It is used in many places. In the CAN code, the static implementation of |
694bc9e
to
e250d27
Compare
f3ec641
to
b313b2f
Compare
b313b2f
to
048cc4e
Compare
no longer needed |
Contribution description
To get the same modules loaded with and without TEST_KCONFIG, I had to fix a few dependencies with the gnrc_pktbuf shell command and STM32
periph_can
.Since
conn_can
has a dependency tognrc_pkt
, some modules are defined in the can Kconfig file. They should be removed once GNRC is fully migrated to Kconfig (some files already exists but seem to use an absolete strategy).Testing procedure
Issues/PRs references
Tick one item in #16875