Makefile.include: Generate lst file using objdump #19745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
CI: ready for build
bergzand
requested changes
Jun 20, 2023
nandojve
force-pushed
the
generate_lst_file
branch
from
35a9470 to
25ff582
Compare
|
ping |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 23, 2023
19745: Makefile.include: Generate lst file using objdump r=maribu a=nandojve ### Contribution description The MAP file does not provide all information necessary to do a full analize of generated code. This automatically generate the LST file with all relavant C and ASM code to help inspect code generated. ### Testing procedure This was tested using AVR and Cortex-M toolchains. Co-authored-by: Gerson Fernando Budke <[email protected]>
|
Build failed: |
nandojve
force-pushed
the
generate_lst_file
branch
from
25ff582 to
5881cf4
Compare
|
There is an issue with objdump for xtensa. It stay on a infinite loop generating the LST file. |
|
Hi @maribu , can you try again if the change is fine? |
maribu
approved these changes
Jun 29, 2023
The MAP file does not provide all information necessary to do a full analize of generated code. This automatically generate the LST file with all relavant C and ASM code to help inspect code generated. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
generate_lst_file
branch
from
5881cf4 to
ae61702
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
added a commit
that referenced
this pull request
Jul 5, 2023
19797: Makefile.include: don't use target lstfile implicitly r=maribu a=gschorcht ### Contribution description This PR reverts a part of PR #19745. It removes the `$(LSTFILE)` from the `BUILD_FILES` variable so that the `.lst` file isn't generated implicitly. If the `.lst` file is needed, it can be generated with `lstfile` target. **Background** The compilation time increased a lot with PR #19745. The reason is that the generation of the `.lst` file seems to be time-consuming. For example, on an Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz` with 8 cores and a SSD, it takes about 15 seconds for a complex application such as `tests/sys/usbus_msc` for a STM32F7 MCU. Therefore, the compilation time for ``` BOARD=stm32f723e-disco make -j8 -C tests/sys/usbus_msc ``` increased from about 1 sec to about 16 seconds (all source files were already compiled). Even for a small application ``` BOARD=stm32f723e-disco make -j8 -C tests/sys/shell ``` the compilation time increased from about 1 sec to about 10 seconds. ### Testing procedure Green CI ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The MAP file does not provide all information necessary to do a full analize of generated code. This automatically generate the LST file with all relavant C and ASM code to help inspect code generated.
Testing procedure
This was tested using AVR and Cortex-M toolchains.