Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/adafruit-itsybitsy-nrf52: Add configuration for DotStar LED #19841

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jimporter
Copy link
Contributor

Contribution description

This adds the configuration for the on-board DotStar/APA102 LED for the adafruit-itsybitsy-nrf52. I based the change on the board definitions for the adafruit-itsybitsy-m4, which also has a DotStar.

I also fixed a small error in the doc. The other LED is red, not blue. See here (I can also verify by looking at the board in person):

Red LED for general purpose blinking, mini DotStar RGB LED for colorful feedback

Testing procedure

I tested this on the board using the program in tests/drivers/apa102 and all looks correct to me.

Issues/PRs references

N/A

@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels Jul 22, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 24, 2023
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jul 24, 2023
@riot-ci
Copy link

riot-ci commented Jul 24, 2023

Murdock results

✔️ PASSED

a712d29 boards/adafruit-itsybitsy-nrf52: Add configuration for DotStar LED

Success Failures Total Runtime
550 0 550 02m:16s

Artifacts

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 24, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit bff7452 into RIOT-OS:master Jul 24, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants