Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lwext4: small fixes #20053

Merged
merged 4 commits into from
Nov 9, 2023
Merged

pkg/lwext4: small fixes #20053

merged 4 commits into from
Nov 9, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Nov 7, 2023

Contribution description

  • Enable mounting SD cards with ext2/3/4 with the new SDMMC driver
  • disable debug strings by default
  • don't consider the fs mounted if recovery fails with some error
  • (unrelated, but trivial) fix output of malloc_tracing

Testing procedure

Issues/PRs references

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 7, 2023
@github-actions github-actions bot added Area: pkg Area: External package ports Area: drivers Area: Device drivers Area: sys Area: System labels Nov 7, 2023
@benpicco benpicco requested review from maribu and gschorcht and removed request for maribu November 7, 2023 18:12
@riot-ci
Copy link

riot-ci commented Nov 7, 2023 •
edited
Loading

Murdock results

✔️ PASSED

e2cee42 pkg/lwext4: don't consider fs mounted if recover fails

Success Failures Total Runtime
7953 0 7953 10m:53s

Artifacts

@benpicco benpicco mentioned this pull request Nov 7, 2023
Merged
@kaspar030
Copy link
Contributor

pls rebase

@kaspar030
Copy link
Contributor

pls let me do the merging here, I'd like to try a rollup with #20050.

@kaspar030 kaspar030 added this pull request to the merge queue Nov 9, 2023
@kaspar030
Copy link
Contributor

pls let me do the merging here, I'd like to try a rollup with #20050.

it didn't do a rollup. 😞 Nevermind.

Merged via the queue into RIOT-OS:master with commit ed52c41 Nov 9, 2023
@benpicco benpicco deleted the lwext4_fixes branch November 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: pkg Area: External package ports Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @kaspar030 @maribu