Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanocoap: implement coap_find_uri_query() #20273

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

This adds a new function coap_find_uri_query() with which we can find a URI query on a request packet.

This makes handling requests with query options easier as we don't have to manually iterate all options in the handler.

Testing procedure

tests-nanocoap was extended to exercise the new function.

Issues/PRs references

suggested in #20197

@github-actions github-actions bot added Area: network Area: Networking Area: tests Area: tests and testing framework Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Jan 18, 2024
@benpicco benpicco requested a review from chrysn January 18, 2024 14:02
@benpicco benpicco changed the title Coap find uri query nanocoap: implement coap_find_uri_query() Jan 18, 2024
@benpicco benpicco requested a review from HendrikVE January 18, 2024 14:03
@benpicco benpicco added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jan 18, 2024
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition in general, smaller comments below.

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that looks much cleaner and good to me now! :)

@benpicco benpicco force-pushed the coap_find_uri_query branch from 07e6579 to 4c7fc01 Compare January 19, 2024 09:53
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 19, 2024
@riot-ci
Copy link

riot-ci commented Jan 19, 2024

Murdock results

✔️ PASSED

4c7fc01 tests/unittests: nanocoap: add test for coap_find_uri_query()

Success Failures Total Runtime
8623 0 8623 11m:34s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 19, 2024
@benpicco
Copy link
Contributor Author

Thank you for the review!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@benpicco benpicco added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@benpicco benpicco added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@benpicco benpicco added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@benpicco benpicco added this pull request to the merge queue Jan 20, 2024
Merged via the queue into RIOT-OS:master with commit 8dbe2ef Jan 20, 2024
25 checks passed
@benpicco benpicco deleted the coap_find_uri_query branch January 20, 2024 15:51
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants