Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu: Add start and end markers for flash_writable section #20308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cpu: Add start and end markers for flash_writable section #20308

wants to merge 1 commit into from
+6 −0

Conversation

Ollrogge
Copy link
Member

Contribution description

This PR adds start and end markers for the flash_writable section. For the ESP32x SoCs these were already added in #19079.

@github-actions github-actions bot added Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports labels Jan 29, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 29, 2024
@benpicco
Copy link
Contributor

What are they used for?
I can't find any reference outside ESP32 code

@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 29, 2024
@RIOT-OS RIOT-OS deleted a comment from riot-ci Jan 29, 2024
@Ollrogge
Copy link
Member Author

What are they used for? I can't find any reference outside ESP32 code

Not directly inside RIOT but I needed these markers to assess the size and location of the region to model it in an emulator. So I thought it would make sense to add them in cases other people want this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ollrogge @benpicco