-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coap: ensure DTLS buffer is at least 200 bytes #20434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
Area: Networking
Area: CoAP
Area: Constrained Application Protocol implementations
Area: sys
Area: System
labels
Feb 26, 2024
benpicco
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Feb 26, 2024
chrysn
reviewed
Feb 26, 2024
benpicco
force-pushed
the
DTLS_MAX_BUF-fix
branch
from
February 27, 2024 16:05
4240b83
to
cb0de24
Compare
fabian18
reviewed
Feb 28, 2024
fabian18
reviewed
Feb 28, 2024
*ding dong it's release' o'clock * Ping @benpicco |
benpicco
force-pushed
the
DTLS_MAX_BUF-fix
branch
from
April 3, 2024 19:09
cb0de24
to
589663b
Compare
I now use a |
benpicco
force-pushed
the
DTLS_MAX_BUF-fix
branch
from
April 3, 2024 19:12
589663b
to
11b4564
Compare
@Teufelchen1 can this still get into the release? It fixes a regression. |
Teufelchen1
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: CoAP
Area: Constrained Application Protocol implementations
Area: network
Area: Networking
Area: sys
Area: System
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The initial DTLS handshake can be larger than a block in CoAP block-wise.
#19892 reduced the DTLS buffer to a CoAP block size + 36 bytes.
This has proven to be too little, breaking DTLS clients.
Bump
DTLS_MAX_BUF
to be at least 200 bytes as this has proven to work well in the past.Testing procedure
First, create the tap interfaces by running
sudo dist/tools/tapsetup/tapsetup
.In one terminal, run the GCoAP DTSL server:
make -C examples/gcoap_dtls PORT=tap1 all term
In another terminal, run the nanoCoAP DTLS client:
make -C tests/net/nanocoap_cli PORT=tap0 all term
In
master
this would yieldIssues/PRs references
follow-up to #19892