drivers/pcf857x: stop (ab)using gpio_t #20435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Type: bug
maribu
approved these changes
Feb 27, 2024
The driver only supports addressing GPIOs by their index, (ab)using `gpio_t` for that will break on platforms that encode GPIO values differently.
benpicco
force-pushed
the
drivers/pcf857x-gpio_t
branch
from
34dcd5c to
e8a4def
Compare
|
Thanks for fixing this right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The driver only supports addressing GPIOs by their index, (ab)using
gpio_tfor that will break on platforms that encode GPIO values differently.Testing procedure
I don't have the hardware to test this, but this should be a simple conversion as the driver expects that
gpio_tjust encodes the pin number in lower 3 bits ofgpio_t.It never accesses the 'port' bits (which would be implementation defined anyway).
Issues/PRs references
triggered some unnecessary workarounds in #20431