Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc/ipv6_auto_subnets: clarify documentation #20446

Merged
merged 1 commit into from
Mar 7, 2024
Merged

gnrc/ipv6_auto_subnets: clarify documentation #20446

merged 1 commit into from
Mar 7, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 5, 2024

Contribution description

The wording was a bit confusing, clarify which subnets are meant.

Testing procedure

Issues/PRs references

@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 5, 2024
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Mar 5, 2024
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Mar 5, 2024
@riot-ci
Copy link

riot-ci commented Mar 5, 2024

Murdock results

✔️ PASSED

233902b gnrc/ipv6_auto_subnets: clarify documentation

Success Failures Total Runtime
1 0 1 13s

Artifacts

@benpicco benpicco added the Area: doc Area: Documentation label Mar 5, 2024
@benpicco benpicco requested review from fabian18 and kfessel March 7, 2024 13:13
kfessel
kfessel approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this only adds some words i assume it still renders correctly

@benpicco benpicco added this pull request to the merge queue Mar 7, 2024
Merged via the queue into RIOT-OS:master with commit 4d2b2f7 Mar 7, 2024
30 checks passed
@benpicco benpicco deleted the net/gnrc/routing/ipv6_auto_subnets-docfix branch March 8, 2024 17:24
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@fabian18 fabian18 Awaiting requested review from fabian18

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @kfessel @MrKevinWeiss