Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build system: add netif_openwsn feature #20695

Merged
merged 4 commits into from
May 28, 2024
Merged

build system: add netif_openwsn feature #20695

merged 4 commits into from
May 28, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented May 24, 2024 •
edited
Loading

Contribution description

Boards / MCUs now provide the newly introduced netif_openwsn feature if they have a network interface supported by OpenWSN. The package now depends on this feature.

With that in place, the white lists of boards supporting OpenWSN in the OpenWSN test apps can now be dropped (and in fact, are dropped).

Testing procedure

The CI should build the OpenWSN test apps for all boards it did before, plus more compatible. The diff of make info-boards-supported is:

+acd52832
 adafruit-clue
 adafruit-itsybitsy-nrf52
+airfy-beacon
 arduino-nano-33-ble
+arduino-nano-33-ble-sense
+calliope-mini
 cc2538dk
+dwm1001
+e104-bt5010a-tb
+e104-bt5011a-tb
 feather-nrf52840
+feather-nrf52840-sense
 firefly
+generic-cc2538-cc2592-dk
+hamilton
 iotlab-a8-m3
 iotlab-m3
+microbit
+microbit-v2
+mulle
+nrf51dk
+nrf51dongle
+nrf52832-mdk
 nrf52840-mdk
+nrf52840-mdk-dongle
 nrf52840dk
 nrf52840dongle
+nrf52dk
+nrf6310
 omote
 openmote-b
 particle-argon
 particle-boron
 particle-xenon
+pinetime
 reel
 remote-pa
 remote-reva
 remote-revb
+ruuvitag
 samr21-xpro
 samr30-xpro
+thingy52
+waveshare-nrf52840-eval-kit
+yunjia-nrf51822

(Hence, no board for them whitelist is gone, but new boards became supported.)

The CI will test if indeed all those boards are compatible.

Issues/PRs references

Contains the last fix for #20680

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: network Area: Networking Area: tests Area: tests and testing framework Area: build system Area: Build system Area: pkg Area: External package ports Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels May 24, 2024
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Platform: native Platform: This PR/issue effects the native platform Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: network Area: Networking Area: tests Area: tests and testing framework Area: pkg Area: External package ports Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels May 24, 2024
@maribu maribu mentioned this pull request May 24, 2024
Merged
@riot-ci
Copy link

riot-ci commented May 24, 2024 •
edited
Loading

Murdock results

✔️ PASSED

61679fb tests/pkg/openwsn*: drop whitelist

Success Failures Total Runtime
10143 0 10143 19m:44s

Artifacts

mguetschow
mguetschow approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning and code changes look good to me!

@maribu maribu force-pushed the pkg/openwsn/feature branch from e559bc3 to a697b01 Compare May 27, 2024 13:40
@maribu maribu removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 27, 2024
@maribu maribu enabled auto-merge May 27, 2024 13:40
@github-actions github-actions bot added the Platform: ARM Platform: This PR/issue effects ARM-based platforms label May 27, 2024
@github-actions github-actions bot added Area: network Area: Networking Area: tests Area: tests and testing framework Area: pkg Area: External package ports Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels May 27, 2024
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 27, 2024
@maribu maribu added this pull request to the merge queue May 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 27, 2024
maribu added 4 commits May 27, 2024 22:56
@maribu
build system: add netif_openwsn feature
798793e 
Boards / MCUs now provide the newly introduced  netif_openwsn feature
if they have a network interface supported by OpenWSN.
@maribu
pkg/openwsn: correctly add dependencies
aa084dd 
OpenWSN requires a compatible network interface (feature
`netif_openwsn`) and UART (at least `UART_NUMOF` needs to be provided).
@maribu
pkg/openwsn: Add missing include
4cf1d5e 
`UART_NUMOF` is defined in `periph_conf.h`, not in `board.h`.
@maribu
tests/pkg/openwsn*: drop whitelist
61679fb 
Now that OpenWSN depends on netif_openwsn, there is no need for
manually tracking which boards are supported
@maribu maribu force-pushed the pkg/openwsn/feature branch from a697b01 to 61679fb Compare May 27, 2024 20:57
@maribu maribu enabled auto-merge May 27, 2024 20:57
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 28, 2024
@maribu maribu added this pull request to the merge queue May 28, 2024
Merged via the queue into RIOT-OS:master with commit 65aaeae May 28, 2024
27 checks passed
@maribu maribu deleted the pkg/openwsn/feature branch May 28, 2024 16:11
@maribu
Copy link
Member Author

maribu commented May 28, 2024

Thx :)

@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@benpicco benpicco Awaiting requested review from benpicco

@dylad dylad Awaiting requested review from dylad dylad is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @mguetschow