Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/event: change example in doc to be type safe #20706

Merged
merged 1 commit into from
May 29, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented May 29, 2024

Contribution description

C is not a particularly safe language, but let's at least encourage best practices so that the few safety features C have are effectively used.

Testing procedure

The example code should compile and not contain casts where not needed.

Issues/PRs references

#20704

C is not a particularly safe language, but let's at least encourage
best practices so that the few safety features C have are effectively
used.
@maribu maribu requested a review from mguetschow May 29, 2024 09:11
@maribu maribu added Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 29, 2024
@github-actions github-actions bot added the Area: sys Area: System label May 29, 2024
@riot-ci
Copy link

riot-ci commented May 29, 2024

Murdock results

✔️ PASSED

00db1df sys/event: change example in doc to be type safe

Success Failures Total Runtime
1 0 1 01m:10s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's even better :)

@mguetschow mguetschow enabled auto-merge May 29, 2024 09:16
@mguetschow mguetschow added this pull request to the merge queue May 29, 2024
Merged via the queue into RIOT-OS:master with commit bceb99c May 29, 2024
29 checks passed
@maribu maribu deleted the sys/event/doc/type-safety branch May 29, 2024 09:43
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants