Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: clean up remnants of THREAD_CREATE_STACKTEST #20893

Merged
merged 1 commit into from
Oct 8, 2024
Merged

treewide: clean up remnants of THREAD_CREATE_STACKTEST #20893

merged 1 commit into from
Oct 8, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 7, 2024

Contribution description

Those were missed in #20450

Testing procedure

No functional changes.

Issues/PRs references

follow-up to #20450

@github-actions github-actions bot added Area: network Area: Networking Area: tests Area: tests and testing framework Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Oct 7, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 7, 2024
@benpicco benpicco requested a review from mguetschow October 7, 2024 15:34
@riot-ci
Copy link

riot-ci commented Oct 7, 2024

Murdock results

✔️ PASSED

97128ee treewide: clean up remnants of THREAD_CREATE_STACKTEST

Success Failures Total Runtime
10196 0 10197 17m:33s

Artifacts

mguetschow
mguetschow requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I also found THREAD_CREATE_STACKTEST in tests/rust_libs and tests/sys/shell_ble on current master, would you mind updating those here, too?

@benpicco
Copy link
Contributor Author

benpicco commented Oct 8, 2024

I can't find them - where are they?

@mguetschow
Copy link
Contributor

Ah sorry, my bad. Both actually symlink to tests/sys/shell which you've adapted already.

@mguetschow mguetschow enabled auto-merge October 8, 2024 09:55
@mguetschow mguetschow added this pull request to the merge queue Oct 8, 2024
Merged via the queue into RIOT-OS:master with commit a54ba26 Oct 8, 2024
30 checks passed
@benpicco benpicco deleted the THREAD_CREATE_STACKTEST-cleanup branch October 8, 2024 13:55
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @riot-ci @mguetschow