Enable the DNS resolution in examples by default #21116
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegHahm
force-pushed
the
pr/feature/enable_dns_in_examples_by_default
branch
from
dcd6bec to
9f15342
Compare
This was referenced Jan 2, 2025
mguetschow
added
the
CI: ready for build
Teufelchen1
requested changes
Jan 24, 2025
Comment on lines
20
to
22
| # Optionally include remoteDNS support. This includes resolution of names at an | ||
| # upstream DNS server and the handling of RDNSS options in Router Advertisements | ||
| # to auto-configure that upstream DNS server. |
There was a problem hiding this comment.
It's now longer optionally if it is the default? I mean, not wrong but sounds misleading. I also believe you should add a pointer that disabling it is safe and yields smaller builds.
benpicco
reviewed
Jan 24, 2025
| # USEMODULE += sock_dns # include DNS client | ||
| # USEMODULE += gnrc_ipv6_nib_dns # include RDNSS option handling | ||
| USEMODULE += sock_dns # include DNS client | ||
| USEMODULE += gnrc_ipv6_nib_dns # include RDNSS option handling | ||
|
|
There was a problem hiding this comment.
You might also want to enable the dns_cache module - otherwise you'll make a new DNS request each time you resolve an address.
Might be worth adding a dns_default pseudo-module that includes all that, so a user only has to enable a single module for full DNS support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The example applications
gnrc_networkingandpaho-mqttare quite useful for testing and/or demonstrating RIOT's networking capabilities. For convenience the use of hostnames instead of IP addresses is preferable. So far, DNS resolution has been disabled by default. IMO it would be much nicer - particularly for newbies, if DNS resolution would work out of the box.The downside: approx. 3k more ROM and about 160 Bytes more RAM usage (on ARM-Cortex). So, I expect this PR to fail on some constrained platforms. However, I think for an example application this is still bearable.
Testing procedure
Test with native
dist/tools/tapsetup/tapsetup -c 1 -u eth0).make -C example/paho-mqtt clean all term.con test.mosquitto.orgTest on 6lowpan hardware
BOARD=nrf52840dk make -C example/paho-mqtt clean all flash term.con test.mosquitto.orgIssues/PRs references
Another PR which configures a DNS resolver on the 6lbr example by default is about to come.