-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "sock/udp: work around gnrc_sock_recv() returning early timeout" #21126
Revert "sock/udp: work around gnrc_sock_recv() returning early timeout" #21126
Conversation
This reverts commit e3d0068, which added a work around for two bugs: - ztimer triggering too early (fixed in RIOT-OS#20924) - gnrc_sock_recv() returning when an old "timeout" message is still in the message queue (fixed in RIOT-OS#21113) With those bugs fixed, the work around should not longer be needed.
I am assuming that it is intentional that you did not revert the other commit (c4634f5) in the referenced PR, but would like confirmation that it wasn't forgotten. |
I can later run |
I assumed something along those lines. If you don't get to it today, I will likely attempt to generate the makefile tonight. |
I managed to get the Makefile generator going. It's now running on this branch. I'll check the result in the morning. |
ping @Enoch247 any update, I wouldn't mind getting this in for the release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran make generate-Makefile.ci
in examples/gcoap
. As suspected, the two boards (saml10-xpro
and saml11-xpro
) still have insufficient memory after this patch will be applied.
My test also showed that atxmega-a3bu-xplained
has insufficient memory to build this branch, but re-running it on the branche's parent (ade999a) shows that condition existed before this branch. So maybe that is an artifact of my setup or a problem caused elsewhere.
Contribution description
This reverts commit e3d0068, which added a work around for two bugs:
With those bugs fixed, the work around should not longer be needed.
Testing procedure
@benpicco has a test setup with dozen of native instances.
Issues/PRs references
#19965