Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.cflags: Make -fno-common the default #2352

Merged
merged 1 commit into from
Jan 30, 2015
Merged

Makefile.cflags: Make -fno-common the default #2352

merged 1 commit into from
Jan 30, 2015

Conversation

jnohlgard
Copy link
Member

To catch sneaky issues with multiply defined global variables. See #2344

@jnohlgard jnohlgard added the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 25, 2015
@jnohlgard
Copy link
Member Author

Needs the msg_q fixes from #2348 before it will build the rpl_udp example.

@jnohlgard jnohlgard added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system and removed Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 25, 2015
@jnohlgard jnohlgard force-pushed the pr/fno-common-default branch from 9f95da9 to 669a412 Compare January 26, 2015 08:13
@jnohlgard
Copy link
Member Author

Rebased after merging #2348

@jnohlgard jnohlgard removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 26, 2015
@jnohlgard jnohlgard added this to the Release NEXT MAJOR milestone Jan 26, 2015
@OlegHahm
Copy link
Member

Sounds like a very good idea to me. ACK

jnohlgard pushed a commit that referenced this pull request Jan 30, 2015
Merge pull request #2352 from gebart/pr/fno-common-default
fe07678 
Makefile.cflags: Make -fno-common the default
@jnohlgard jnohlgard merged commit fe07678 into RIOT-OS:master Jan 30, 2015
@jnohlgard
Copy link
Member Author

Merged.

This was referenced Feb 1, 2015
Closed
Closed
@jnohlgard jnohlgard deleted the pr/fno-common-default branch February 6, 2015 13:38
@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Release 2015.06 Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels
Area: build system Area: Build system Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.
3 participants
@jnohlgard @OlegHahm @LudwigKnuepfer