Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/openocd.sh: added shutdown to flash commands #2471

Merged
merged 2 commits into from
Mar 5, 2015
Merged

dist/openocd.sh: added shutdown to flash commands #2471

merged 2 commits into from
Mar 5, 2015

Conversation

haukepetersen
Copy link
Contributor

fixes #2470

@haukepetersen haukepetersen added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Feb 19, 2015
@OlegHahm
Copy link
Member

Does this fix the problem for STM32f4 as well?

@haukepetersen haukepetersen mentioned this pull request Feb 19, 2015
Closed
@haukepetersen
Copy link
Contributor Author

yapp. That problem was no real problem, it was just because of my own stupidity...

@haukepetersen
Copy link
Contributor Author

actually without this PR the stm shows the same behavior than the atmel board with the newest OpenOCD version...

@haukepetersen
Copy link
Contributor Author

hm, but there seems to be some other trouble - Make is exiting from make flash with some Error.

@OlegHahm
Copy link
Member

Like I've written in #2470. ;)

@haukepetersen
Copy link
Contributor Author

ups, that part I did not read...

@haukepetersen
Copy link
Contributor Author

ok, here is a small workaround - what do you say?

@LudwigKnuepfer
Copy link
Member

Can't you figure out why openocd exits with a non-zero exit code?

@haukepetersen
Copy link
Contributor Author

probably, but not at the moment...

@LudwigKnuepfer
Copy link
Member

Then at least add a comment in there.

@OlegHahm
Copy link
Member

I made a patch for OpenOCD: OlegHahm/openocd@61c1263

To me it looks like that the command value for shutdown is interpreted as an error value without this patch.

@OlegHahm
Copy link
Member

The behavior was introduced in openocd-org/openocd@a35712a8

@LudwigKnuepfer
Copy link
Member

So ... the comment should point to the issue (which has to be created first?) over at openocd?

@OlegHahm OlegHahm mentioned this pull request Feb 19, 2015
Closed
@OlegHahm
Copy link
Member

#2472 should do the trick in a sensible way.

@OlegHahm
Copy link
Member

OlegHahm commented Mar 3, 2015

How about we merge this, but leave #2472 open until newer OpenOCD versions are available in most distributions (preferably even in Ubuntu LTS)?

@haukepetersen
Copy link
Contributor Author

don't really like the idea of keeping #2472 open for (what could be) a long time. I would rather merge this PR and close #2472, and then just revisit this in a year or so. And if we really forget about it by then, it's not like overwriting the openOCD return value does break anything...

@OlegHahm
Copy link
Member

OlegHahm commented Mar 4, 2015

We have issues that are open for far more time and I hope that even Ubuntu people aren't that slow. Ignoring the OpenOCD return value is not a clean solution in my opinion.

@haukepetersen
Copy link
Contributor Author

true

OlegHahm added a commit that referenced this pull request Mar 5, 2015
@OlegHahm
Merge pull request #2471 from haukepetersen/fix_openocd_shutdown
96e6d2a 
dist/openocd.sh: added shutdown to flash commands
@OlegHahm OlegHahm merged commit 96e6d2a into RIOT-OS:master Mar 5, 2015
@haukepetersen haukepetersen deleted the fix_openocd_shutdown branch March 6, 2015 10:12
@OlegHahm OlegHahm mentioned this pull request May 2, 2015
Merged
@kaspar030
Copy link
Contributor

Seems upstream openocd got fixed. See #2897.

@OlegHahm
Copy link
Member

OlegHahm commented May 8, 2015

But OpenOCD in Ubuntu is still 0.8, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flashing is not working on SAMR21 any more
4 participants
@haukepetersen @OlegHahm @LudwigKnuepfer @kaspar030