Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_icmpv6_error: Initial import of IPv6 error convenience functions #3544

Merged
merged 1 commit into from
Mar 3, 2016
Merged

gnrc_icmpv6_error: Initial import of IPv6 error convenience functions #3544

merged 1 commit into from
Mar 3, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 3, 2015

Allows for sending ICMPv6 error messages and releasing the invoking packet with a fitting error code in one call.

Depends on #3184 and #3362. (merged)

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Aug 3, 2015
@miri64 miri64 added this to the Release NEXT MAJOR milestone Aug 3, 2015
@OlegHahm OlegHahm modified the milestones: Release 2015.12, Release 2016.03 Dec 3, 2015
@miri64 miri64 mentioned this pull request Dec 24, 2015
Closed
@miri64 miri64 force-pushed the ng_icmpv6_error/feat/send+neterr branch from 0b930ba to 4e13e7e Compare January 23, 2016 15:10
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 23, 2016
@miri64
Copy link
Member Author

miri64 commented Jan 23, 2016

Rebased and adapted to current master

@miri64 miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jan 23, 2016
@miri64 miri64 force-pushed the ng_icmpv6_error/feat/send+neterr branch from 4e13e7e to 0c8e831 Compare January 23, 2016 15:44
@miri64 miri64 changed the title ng_icmpv6_error: Initial import of IPv6 error convenience functions gnrc_icmpv6_error: Initial import of IPv6 error convenience functions Jan 23, 2016
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 25, 2016
@miri64 miri64 force-pushed the ng_icmpv6_error/feat/send+neterr branch from 0c8e831 to afb79c0 Compare January 25, 2016 01:19
@miri64
Copy link
Member Author

miri64 commented Jan 25, 2016

Fixed some pedantic errors.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 25, 2016
@OlegHahm
Copy link
Member

Needs a rebase.

@miri64 miri64 force-pushed the ng_icmpv6_error/feat/send+neterr branch from afb79c0 to 6b950e6 Compare January 27, 2016 02:52
@miri64
Copy link
Member Author

miri64 commented Jan 27, 2016

Rebased.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 27, 2016
@miri64
Copy link
Member Author

miri64 commented Jan 28, 2016

Ready for review ;-)

@DipSwitch
Copy link
Member

Everything seems ok! :) Travis is happy, didn't test... but go? ^_^

OlegHahm
OlegHahm reviewed Feb 15, 2016
View reviewed changes
sys/include/net/gnrc/icmpv6/error.h
#else
(void)code;
#endif
#ifdef MODULE_GNRC_PKTBUF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any GNRC configuration without pktbuf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory for testing I guess.

@OlegHahm
Copy link
Member

@authmillenon, let's get this merged next Tuesday.

@OlegHahm
Copy link
Member

OlegHahm commented Mar 1, 2016

ACK. Please squash!

@miri64 miri64 force-pushed the ng_icmpv6_error/feat/send+neterr branch from 80f20c3 to 43f8487 Compare March 1, 2016 19:40
@miri64
Copy link
Member Author

miri64 commented Mar 1, 2016

Done

miri64 added a commit that referenced this pull request Mar 3, 2016
@miri64
Merge pull request #3544 from authmillenon/ng_icmpv6_error/feat/send+…
5c8ae83 
…neterr

gnrc_icmpv6_error: Initial import of IPv6 error convenience functions
@miri64 miri64 merged commit 5c8ae83 into RIOT-OS:master Mar 3, 2016
@miri64 miri64 deleted the ng_icmpv6_error/feat/send+neterr branch March 3, 2016 03:29
@miri64
Copy link
Member Author

miri64 commented Mar 3, 2016

Finally merged \o/

@OlegHahm
Copy link
Member

OlegHahm commented Mar 3, 2016

Hooray!

@miri64 miri64 mentioned this pull request Mar 12, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @OlegHahm @DipSwitch