Shell uart0 newlib distinction #3555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegHahm
added
Type: enhancement
OlegHahm
added
the
CI: ready for build
OlegHahm
added
the
CI: needs squashing
OlegHahm
added a commit
to OlegHahm/applications
that referenced
this pull request
Aug 4, 2015
Related and dependent on RIOT-OS/RIOT#3555
|
shouldn't #3402 fix this situation for all platforms? |
|
Only if all platforms support getchar() which is currently not the case. |
|
Agreed, #3402 would be the nicer way, but seems on some platforms. (Builds, but won't react to input any more.) |
|
As we are fixing (or waiting for Travis to accept our fixes) these errors, we go with #3402, right? So should we close this PR? |
|
Agreed. |
This was referenced Aug 21, 2015
chrysn
pushed a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Sep 20, 2022
Related and dependent on RIOT-OS#3555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #3550 as long as uart0 is not phased out.