Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix: sockets: use correct datatypes for in6_addr #4160

Merged
merged 1 commit into from
Oct 27, 2015
Merged

posix: sockets: use correct datatypes for in6_addr #4160

merged 1 commit into from
Oct 27, 2015

Conversation

OlegHahm
Copy link
Member

in6addr_any and in6addr_loopback are of type in6_addr.

Not sure if there was any intention behind making these variables of type sockaddr_in6 instead, but this makes porting of POSIX compliant code more difficult.

@OlegHahm OlegHahm added Area: POSIX Area: POSIX API wrapper Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Oct 26, 2015
@miri64
Copy link
Member

miri64 commented Oct 27, 2015

ACK, if travis is happy.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 27, 2015
@OlegHahm
posix: sockets: use correct datatypes for in6_addr
a0dcbc6 
in6addr_any and in6addr_loopback are of type in6_addr
@OlegHahm OlegHahm force-pushed the posix_socket_in6_addr_datatype branch from 0389470 to a0dcbc6 Compare October 27, 2015 10:39
@OlegHahm
Copy link
Member Author

Removed trailing spaces and squashed immediately.

@cgundogan
Copy link
Member

kicked travis

@cgundogan cgundogan added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Oct 27, 2015
@OlegHahm
Copy link
Member Author

Travis is green and I have no idea what strider is telling me.

OlegHahm added a commit that referenced this pull request Oct 27, 2015
@OlegHahm
Merge pull request #4160 from OlegHahm/posix_socket_in6_addr_datatype
c1d9b5e 
posix: sockets: use correct datatypes for in6_addr
@OlegHahm OlegHahm merged commit c1d9b5e into RIOT-OS:master Oct 27, 2015
@OlegHahm OlegHahm deleted the posix_socket_in6_addr_datatype branch October 27, 2015 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: network Area: Networking Area: POSIX Area: POSIX API wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegHahm @miri64 @cgundogan