Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32f1/i2c: Disable I2C module before initialization #4198

Merged
merged 1 commit into from
Nov 17, 2015

Conversation

thomaseichinger
Copy link
Member

When initializing multiple drivers connected to the same
I2C bus, the bus should be disabled before pin toggeling
and reinitialisation. Fixes #4197

When initializing multiple drivers connected to the same
I2C bus, the bus should be disabled before pin toggeling
and reinitialization.
@thomaseichinger thomaseichinger added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers labels Nov 1, 2015
@thomaseichinger thomaseichinger added this to the Release 2015.12 milestone Nov 1, 2015
@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2015
@haukepetersen
Copy link
Contributor

+1 -> ACK

Though this brings us back to the discussion of initializing buses outside of device drivers, right?

@PeterKietzmann
Copy link
Member

yep...

@jnohlgard
Copy link
Member

for reference: #2528

haukepetersen added a commit that referenced this pull request Nov 17, 2015
stm32f1/i2c: Disable I2C module before initialization
@haukepetersen haukepetersen merged commit 047f754 into RIOT-OS:master Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants