sys/net/gnrc/conn/gnrc_conn.c: release pkt in gnrc_conn_recvfrom #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
added
Type: bug
| @@ -83,6 +83,7 @@ int gnrc_conn_recvfrom(conn_t *conn, void *data, size_t max_len, void *addr, siz | |||
| *addr_len = _srcaddr(addr, l3hdr); | |||
| } | |||
| memcpy(data, pkt->data, pkt->size); | |||
| gnrc_pktbuf_release(pkt); | |||
| return pkt->size; | |||
There was a problem hiding this comment.
That's a pity, but in principle is it a right place for gnrc_pktbuf_release?
There was a problem hiding this comment.
Yes, you just have to store the value before release ;-)
|
@authmillenon done |
|
ACK, please squash. |
miri64
added
the
CI: needs squashing
jfischer-no
added
CI: ready for build
|
& go. |
miri64
added a commit
that referenced
this pull request
Nov 2, 2015
sys/net/gnrc/conn/gnrc_conn.c: release pkt in gnrc_conn_recvfrom
|
Can you PR a version of this fix to the release branch too, please. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gnrc_pktbuf_release to gnrc_conn_recvfrom.
It fixes pkt memory leak what I have observed in #4189.