-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc nettype: always include all nettypes #4235
Conversation
Even if an application cannot process a certain protocol, it might be able to handle it somehow.
Can you chalets the buildsizes please? Will explain tomorrow. |
For this demux_ctx exist. |
What if there is an Ethertype set to IPv6 in a L2 packet for instance? And what about #4189 (which was the reason for me to introduce this)? |
About 32 bytes more ROM usage and 8 bytes more RAM usage on Cortex-M platforms. |
|
I have to admit that I don't like this, but cannot think of another solution right now (except for ugly ones). I don't understand your solution for #4189 though, can you make a proposal? |
I discussed this with @emmanuelsearch and @haukepetersen today, and we came to the decission that your solution wouldn't really hurt that much: As you've said the additional RAM usage is minimal (though I'm not quite sure which app you mean). On the plus side it would make a lot of code easier to read, so let's go for it. |
ACK if OP is okay with reopening this PR and Travis is happy. |
Oops, sorry, I think I tested with gnrc_border_router. So, it's probably only the RAM overhead for one additional nettype (UDP) in this case. |
Did you re-test with other set-ups @OlegHahm? |
Not yet. Will do ASAP. |
Any news here? |
Nope. |
Then I would like to close this PR, since I imagine it to be bigger for more than one nettype. |
Even if an application cannot process a certain protocol, it might be able to handle it somehow.