Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: uncrustify: remove spaces between pointer stars #4268

Merged
merged 1 commit into from
Nov 15, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 13, 2015

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Nov 13, 2015
@miri64 miri64 added this to the Release 2015.12 milestone Nov 13, 2015
@OlegHahm
Copy link
Member

Untested ACK

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 13, 2015
@miri64
Copy link
Member Author

miri64 commented Nov 13, 2015

I encountered an issue with function pointers when trying to uncrustify sys/net/ but I don't think it was related to this.

@miri64
Copy link
Member Author

miri64 commented Nov 13, 2015

Yupp, its unrelated:

[martine@beutlin RIOT]<3 uncrustify -l C -c uncrustify-riot.cfg --no-backup sys/include/net/gnrc/gnrc_netdev2.h
Parsing: sys/include/net/gnrc/gnrc_netdev2.h as language C
[martine@beutlin RIOT]<3 git diff
diff --git a/sys/include/net/gnrc/gnrc_netdev2.h b/sys/include/net/gnrc/gnrc_netdev2.h
index d04c538..1c87584 100644
--- a/sys/include/net/gnrc/gnrc_netdev2.h
+++ b/sys/include/net/gnrc/gnrc_netdev2.h
@@ -65,7 +65,7 @@ struct gnrc_netdev2 {
      * device and convert it into a pktsnip while adding a netif header
      * and possibly marking out higher-layer headers.
      */
-    gnrc_pktsnip_t * (*recv)(gnrc_netdev2_t *dev);
+    gnrc_pktsnip_t * (*recv)(gnrc_netdev2_t * dev);

     /**
      * @brief netdev2 handle this adapter is working with
@@ -91,7 +91,7 @@ struct gnrc_netdev2 {
  * @return KERNEL_PID_UNDEF on error
  */
 kernel_pid_t gnrc_netdev2_init(char *stack, int stacksize, char priority,
-                        const char *name, gnrc_netdev2_t *gnrc_netdev2);
+                               const char *name, gnrc_netdev2_t *gnrc_netdev2);

 #ifdef __cplusplus
 }

@miri64
Copy link
Member Author

miri64 commented Nov 13, 2015

(That result is true for both master and this PR ;-))

@miri64
Copy link
Member Author

miri64 commented Nov 13, 2015

Travis is happy btw.

LudwigKnuepfer added a commit that referenced this pull request Nov 15, 2015
style: uncrustify: remove spaces between pointer stars
@LudwigKnuepfer LudwigKnuepfer merged commit d108a97 into RIOT-OS:master Nov 15, 2015
@miri64 miri64 deleted the style/fix/sp-between-ptr-star branch February 21, 2016 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants