Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_sixlowpan_frag: msg based fragmentation #4436

Merged

Conversation

PeterKietzmann
Copy link
Member

#4381 version for the latest release branch 2015.09

@PeterKietzmann PeterKietzmann added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 8, 2015
@PeterKietzmann
Copy link
Member Author

@authmillenon let's also put it in the "old" release branch!

@miri64
Copy link
Member

miri64 commented Dec 8, 2015

Mh… we are in feature freeze for the next release and discussed to no longer support the old release as of now. @OlegHahm what do you think?

@PeterKietzmann
Copy link
Member Author

  1. Some people call the "fixed" behaviour a bug
  2. Are we already in feature freeze right now :-) ?
  3. You've tested the change and decided to merge it to the current master (to be part of the new release). So it should not break anything
  4. You know that I need the old release branch for some measurements (if things don't change)

@miri64
Copy link
Member

miri64 commented Dec 8, 2015

  1. Yes, but that is argument is void if we drop support for 2015.09
  2. AFAIK yes, since midnight (though I'm not sure since there was no official statement)
  3. Yes, but again, if we don't update 2015.09 anymore, since we have a new and shiny 2015.12, this isn't necessary
  4. I think we'll go for 2015.12 for the measurements, unless there were some hard API changes that make this impossible.

@miri64
Copy link
Member

miri64 commented Dec 8, 2015

In case I am wrong: please add the change from #4437 ;-)

@PeterKietzmann
Copy link
Member Author

Did, in case.....

@OlegHahm
Copy link
Member

OlegHahm commented Dec 8, 2015

Are we already in feature freeze right now :-) ?

Not yet, but very soon.

AFAIK yes, since midnight (though I'm not sure since there was no official statement)

Maybe you should look into your mailbox again. ;)

My first reflex was that this PR is not needed, but thinking about it again it still may help people out there who want to continue with 2015.09 for some time and it just don't hurt.

In general, I think you could save a lot of time by just acking and merging it, instead of discussing about a change that is either useful or superfluous, but definitely not harmful.

OlegHahm added a commit that referenced this pull request Dec 8, 2015
…15-9

gnrc_sixlowpan_frag: msg based fragmentation
@OlegHahm OlegHahm merged commit 0fbb0af into RIOT-OS:2015.09-branch Dec 8, 2015
@miri64
Copy link
Member

miri64 commented Dec 9, 2015

Better save than sorry ;-)

@PeterKietzmann PeterKietzmann deleted the sixlo_frag_unblocking_RB15-9 branch February 29, 2016 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants